Skip to content

feat(slack): session link auto-post + aside filter (merge PR #1 with CI fix)#3

Merged
jld-adriano merged 5 commits intomainfrom
devin/1774997497-merge-pr1-into-main
Mar 31, 2026
Merged

feat(slack): session link auto-post + aside filter (merge PR #1 with CI fix)#3
jld-adriano merged 5 commits intomainfrom
devin/1774997497-merge-pr1-into-main

Conversation

@jld-adriano
Copy link
Copy Markdown

@jld-adriano jld-adriano commented Mar 31, 2026

Summary

Merges the two features from PR #1 (feat/slack-session-link-auto-post) into main, on top of PR #2's GitHub-hosted runner CI fix. The merge resolved CI workflow conflicts by keeping PR #2's runner configuration.

Two changes (29 lines added across 2 files):

  1. Session link auto-post (src/slack/monitor/message-handler/dispatch.ts): When a new thread session starts (IsFirstThreadTurn && message.thread_ts), posts a 🔗 Session link to the thread using OPENCLAW_PUBLIC_URL. Fire-and-forget (.catch swallows errors). No-op if OPENCLAW_PUBLIC_URL is unset.

  2. "aside" prefix filter (src/slack/monitor/message-handler.ts): Messages starting with aside (case-insensitive, after stripping Slack @mentions) are silently dropped before debouncing/dispatch. Lets users have side conversations in threads without triggering the bot.

Review & Testing Checklist for Human

  • Verify aside filter insertion point: The filter is added after trackEvent?.() and before threadTsResolver.resolve() in the message handler's return function (~line 119). Confirm this is early enough to prevent any processing (debounce, dispatch, etc.) for aside messages.
  • Verify dispatch.ts session link logic: The IsFirstThreadTurn check and chat.postMessage call are inserted after identity resolution and before direct-message handling. Confirm prepared.ctxPayload.IsFirstThreadTurn is reliably set by the prepare step for new thread sessions.
  • Verify CI workflow files are intact: The merge resolved conflicts in 5 .github/workflows/*.yml files by taking main's version (GitHub-hosted runners from PR ci: switch from Blacksmith to GitHub-hosted runners #2). Confirm no PR ci: switch from Blacksmith to GitHub-hosted runners #2 changes were lost.
  • Test plan: Deploy via monorepo submodule update → (1) send aside hello in a bot thread → bot should not respond; (2) send @Bot aside hello → bot should not respond; (3) start a new thread → bot should post a 🔗 Session link before its reply; (4) verify OPENCLAW_PUBLIC_URL is set in the pod env.

Notes

  • The \b word boundary in /^aside\b/i prevents false matches on words like "asides" or "asidebar".
  • The companion monorepo PR (exa-labs/monorepo#27113) that adds OPENCLAW_PUBLIC_URL to deploy.ts is already merged.
  • This PR was NOT tested end-to-end yet — the original PR feat(slack): auto-post session link + skip 'aside' messages #1 had stale CI (Blacksmith runners) that never completed. E2E testing will happen after this merges and the monorepo submodule is updated.

Link to Devin session: https://app.devin.ai/sessions/460eec68d4c74aaa8c85af43c562f11f
Requested by: @jld-adriano


Open with Devin

jld-adriano and others added 3 commits March 31, 2026 20:46
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

jld-adriano and others added 2 commits March 31, 2026 22:58
… post

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@jld-adriano jld-adriano merged commit acf9fc9 into main Mar 31, 2026
20 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant