Skip to content

refactor(esl-image): officially deprecate ESLImage #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ala-n wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(esl-image): officially deprecate ESLImage #3742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/esl-website/src/lib.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
@import './common/colors.less';

@import '@exadel/esl/modules/all.less';
// Legacy imports
@import '@exadel/esl/modules/esl-image/core.less';

@import './common/accent-lines.less';
@import './common/accordion.less';
Expand Down
3 changes: 3 additions & 0 deletions packages/esl-website/src/lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
import '@exadel/esl/modules/lib';
export * from '@exadel/esl';

// Export legacy modules for website demos
export {ESLImage} from '@exadel/esl/modules/esl-image/core';
1 change: 0 additions & 1 deletion packages/esl/src/all.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
@import './esl-utils/all.less';

@import './esl-image/core.less';
@import './esl-image-utils/all.less';
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping esl-image/core.less from the aggregated all.less bundle changes the styling contract for consumers that previously relied on @exadel/esl/modules/all.less to include legacy esl-image styles (e.g., .img-container and [lazy]/[ready] rules). If the goal is a gradual deprecation, consider keeping the import for now (possibly behind a separate legacy bundle) to avoid silent visual regressions, or ensure the removal is clearly communicated as a breaking change.

Suggested change
@import './esl-image-utils/all.less';
@import './esl-image-utils/all.less';
@import './esl-image/core.less';

Copilot uses AI. Check for mistakes.
@import './esl-media/core.less';

Expand Down
1 change: 0 additions & 1 deletion packages/esl/src/all.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export * from './esl-traversing-query/core';
export * from './esl-a11y-group/core';

// Image
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the export * from './esl-image/core' re-export is a breaking API change for consumers that import ESLImage (and related types like ESLImageTagShape) from @exadel/esl (which maps to modules/all). If the intent is to deprecate rather than remove, consider keeping the re-export and relying on @deprecated annotations (or re-exporting with a deprecation notice) for at least one release cycle; otherwise this should be treated/communicated as a removal in the public entrypoint.

Suggested change
// Image
// Image
export * from './esl-image/core';

Copilot uses AI. Check for mistakes.
export * from './esl-image/core';
export * from './esl-image-utils/core';

// Media
Expand Down
2 changes: 2 additions & 0 deletions packages/esl/src/esl-image/core/esl-image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ const isLoadState = (state: string): state is LoadState => ['error', 'loaded', '
* Was originally developed as an alternative to `<picture>` element, but with more features inside.
*
* @author Alexey Stsefanovich (ala'n), Yuliya Adamskaya
* @deprecated use native `<picture>` element or `<img>` with `srcset`, `sizes` and `loading` attributes.
* For additional sugar, see modern esl-image-utils package.
*/
@ExportNs('Image')
export class ESLImage extends ESLBaseElement {
Expand Down
Loading