#237: Fixed the opencode plugin in the doc#238
Conversation
| console.log( | ||
| "[install-exasol-skills] Failed to install skills.", | ||
| ); |
There was a problem hiding this comment.
Also log stdout & stderr of the executed tool to simplify debugging.
| }); | ||
| }); | ||
|
|
||
| const InstallExasolPlugins = async () => { |
There was a problem hiding this comment.
Functions in JS use lower camel case, unless upper camel case is a convention in this context.
| const InstallExasolPlugins = async () => { | |
| const installExasolPlugins = async () => { |
There was a problem hiding this comment.
General: untested code in documentation. Would it be possible to
- extract the code into .js files
- add a small js project with tests
- run tests in CI
- include code from .js files into this documentation?
There was a problem hiding this comment.
I agree it will be better, but it's a bit tricky, especially with the second script that downloads skills from GitHub. The skills might not be there at the time CI runs. It will probably be an overkill. After all, such a script is outside the scope of this project. It's only a kind of advice or suggestion.
|
2 participants
closes #237