Skip to content

Feature/324 adding method to create prepared statements#325

Merged
milenaossoriolami merged 18 commits into
masterfrom
feature/324_adding_method_to_create_prepared_statements
Mar 30, 2026
Merged

Feature/324 adding method to create prepared statements#325
milenaossoriolami merged 18 commits into
masterfrom
feature/324_adding_method_to_create_prepared_statements

Conversation

@milenaossoriolami

@milenaossoriolami milenaossoriolami commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

closes #324

Checklist

Note: If any of the items in the checklist are not relevant to your PR, leave the box unchecked.

For any Pull Request

Is the following correct:

  • the title of the Pull Request?
  • the title of the corresponding issue?
  • there are no other open Pull Requests for the same update/change?
  • that the issue which this Pull Request fixes ("Fixes...") is mentioned?

When Changes Were Made

Did you:

  • update the changelog?
  • update the implementation?
  • check coverage and add tests: unit tests and, if relevant, integration tests?
  • update the User Guide & other documentation?
  • resolve any failing CI criteria (incl. Sonar quality gate)?

When Preparing a Release

Have you:

  • thought about version number (major, minor, patch)?
  • checked Exasol packages for updates and resolved open vulnerabilities, if easily possible?

@milenaossoriolami milenaossoriolami marked this pull request as ready for review March 16, 2026 09:34
Comment thread pyexasol/connection.py
Comment thread pyexasol/connection.py
@ahsimb

ahsimb commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

We test an error when trying to execute a prepared statement after closing it, but I don't think we test closing the connection and then trying to execute the statement.

@milenaossoriolami

Copy link
Copy Markdown
Collaborator Author

We test an error when trying to execute a prepared statement after closing it, but I don't think we test closing the connection and then trying to execute the statement.

I added a test for a closed connection

ahsimb
ahsimb previously approved these changes Mar 20, 2026
@milenaossoriolami milenaossoriolami force-pushed the feature/324_adding_method_to_create_prepared_statements branch from c911c42 to b09f75a Compare March 20, 2026 10:40
ckunki
ckunki previously approved these changes Mar 30, 2026
@ckunki ckunki dismissed stale reviews from ahsimb and themself via af26633 March 30, 2026 07:13
@ckunki ckunki temporarily deployed to manual-approval March 30, 2026 07:13 — with GitHub Actions Inactive
@sonarqubecloud

Copy link
Copy Markdown

@milenaossoriolami milenaossoriolami merged commit a99c84c into master Mar 30, 2026
34 checks passed
@milenaossoriolami milenaossoriolami deleted the feature/324_adding_method_to_create_prepared_statements branch March 30, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding method to create prepared statements

4 participants