Merged
Conversation
keiravillekode
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverse-list, which aims to prove a property about a custom list reversing function (specifically, that it is equivalent to the built-inList.reverse).Right now test files used by exercises do not fail on a warning. This means that
sorry(which is equivalent to "always true" in proofs and only emits a warning) is hard to catch. Added an extra option inlakefile.tomlso that the build fails on any warning.I think that maybe we should add this configuration as default in the template
lakefile.toml. And perhaps we should also modify the test-runner so that online tests run with--wfail(which serves the same purpose).