Add debug#438
Merged
Merged
Conversation
Contributor
Author
|
Changes I didn't make, because I wanted to have your opinions first:
|
keiravillekode
approved these changes
May 10, 2026
keiravillekode
left a comment
Contributor
There was a problem hiding this comment.
We should mention this, and how to %include it, in https://exercism.org/docs/tracks/x86-64-assembly/tests
The ocaml and reasonml tracks use an editor file for the method signature. Otherwise, use of editor is rare.
Contributor
Author
Done |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
debug.macThis PR adds a
debug.macmacro file to the templates directory, with many macros for debugging support (printing to stdout). This file was based on a similar one in the test-runner folder, with the following changes:doublefloating-point values.debug.asmtodebug.mac. That is the default file extension for macro files, which must be included as a whole in anotherasmfile in order to be used. The extension.asmalso makes NASM assemble the file separately and the compiler complains if there is no.note.GNU-stacksection, making the stack executable.Change
bin/update-from-templatesThis script was only copying the
Makefileand the files in thevendorfolder to practice exercises. Added support to concept exercises and to thedebug.macfile, so that this file was propagate to every exercise.This also revealed that the Makefile for practice exercises had a few extra flags not present in the Makefile for concept exercises.
Added a
templates/concept_MakefileConcept exercises don't have an
example.asm, but aexemplar.asm. So I added a second template Makefile for concept exercises with the correct file name.Added support to
doubleinunity.hBy default, Unity doesn't support
double, onlyfloat. This can be changed by adding a#define UNITY_INCLUDE_DOUBLE 1in theunity.hfile. This change doesn't impact tests usingfloat.A few concept exercises already had this flag set (for example,
freelancer-rates), and another that sets a default precision fordoublecomparison. In order to have an uniform treatment, I added both flags totemplates/vendor/unity.hand propagated the change to all exercises.This PR should be merged together with another in the test-runner that adds the complete
debug.macfile. I haven't PRed there yet so I can still make changes here to keep things in sync.