feat: expose busboy defCharset, highWaterMark and fileHwm options - #1465
Open
UlisesGascon wants to merge 1 commit into
Open
feat: expose busboy defCharset, highWaterMark and fileHwm options#1465UlisesGascon wants to merge 1 commit into
UlisesGascon wants to merge 1 commit into
Conversation
Co-authored-by: yokomotod <yokomotod@gmail.com> Co-authored-by: Markku Roponen <roponen.markku@gmail.com>
This was referenced Aug 29, 2026
|
coverage: 99.721% (+0.004%) from 99.717% — feat/busboy-options into main |
This was referenced Aug 29, 2026
Open
kilisamemarisaaa
left a comment
kilisamemarisaaa
left a comment
Contributor
There was a problem hiding this comment.
Independently verified on Windows with Node v24.12.0 at 345bfad: npm test passes (123 passing, 2 pending) and npm run lint is clean. The new busboy-options coverage exercises default/custom defCharset, .any() propagation, fileHwm, and parser highWaterMark; I also traced both _makeMiddleware and any() option paths and found no correctness or compatibility issues. My account cannot submit an APPROVE review without explicit repository access, so this is recorded as a factual verification comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passes busboy's
defCharset,highWaterMarkandfileHwmthroughmulter(opts), next to the existingdefParamCharset, using busboy's option names. Nothing changes when they are not set — busboy keeps its defaults (covered by a test). Note: busboy does not validate the charset name; an unknowndefCharsetyieldsundefinedfield values.Supersedes #488 and #1102 (authors credited as co-authors).
Closes #488
Closes #1102
Closes #320