Skip to content

fix: Ensure FileStorage.close() is called in export operations #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjcoombs wants to merge 5 commits into
base: next
Choose a base branch
from
Open

fix: Ensure FileStorage.close() is called in export operations #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f099a5e
fix: ensure FileStorage.close() is called in export operations
bjcoombs Jan 16, 2026
0b9496f
fix: correct changeset package name and formatting
bjcoombs Jan 16, 2026
c105b37
fix: address CodeRabbit review feedback
bjcoombs Jan 16, 2026
d571bd1
fix: use unknown cast in Response mock for proper TypeScript compatib…
bjcoombs Jan 16, 2026
5e757a7
Merge remote-tracking branch 'upstream/next' into 1585-filestorage-cl…
bjcoombs Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-filestorage-cleanup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"task-master-ai": patch
---

Fix FileStorage resource leaks by ensuring close() is called in try/finally blocks
Copy link
Copy Markdown
Collaborator

@Crunchyman-ralph Crunchyman-ralph Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if close() actually does anything, but hey, why not!

118 changes: 69 additions & 49 deletions apps/cli/src/commands/export.command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,13 @@ export class ExportCommand extends Command {
}

const fileStorage = new FileStorage(projectRoot);
await fileStorage.initialize();
const tagsResult = await fileStorage.getTagsWithStats();
let tagsResult;
try {
await fileStorage.initialize();
tagsResult = await fileStorage.getTagsWithStats();
} finally {
await fileStorage.close();
}

if (!tagsResult.tags || tagsResult.tags.length === 0) {
console.log(chalk.yellow('\nNo local tags found in tasks.json.\n'));
Expand Down Expand Up @@ -389,8 +394,13 @@ export class ExportCommand extends Command {

spinner = ora('Loading tasks...').start();
const fileStorage = new FileStorage(projectRoot);
await fileStorage.initialize();
const tasks = await fileStorage.loadTasks(options?.tag);
let tasks;
try {
await fileStorage.initialize();
tasks = await fileStorage.loadTasks(options?.tag);
} finally {
await fileStorage.close();
}
spinner.succeed(`${tasks.length} tasks`);

if (!tasks || tasks.length === 0) {
Expand Down Expand Up @@ -494,8 +504,13 @@ export class ExportCommand extends Command {
}

const fileStorage = new FileStorage(projectRoot);
await fileStorage.initialize();
const tasks = await fileStorage.loadTasks(options?.tag);
let tasks;
try {
await fileStorage.initialize();
tasks = await fileStorage.loadTasks(options?.tag);
} finally {
await fileStorage.close();
}

if (!tasks || tasks.length === 0) {
console.log(
Expand Down Expand Up @@ -715,57 +730,62 @@ export class ExportCommand extends Command {
return;
}
const fileStorage = new FileStorage(projectRoot);
await fileStorage.initialize();

const exportPromises: Promise<ExportResult>[] = tags.map(async (tag) => {
try {
// Load tasks from LOCAL FileStorage to count parent tasks vs subtasks
const tasks = await fileStorage.loadTasks(tag);
const parentTaskCount = tasks.length;
const subtaskCount = tasks.reduce(
(acc, t) => acc + (t.subtasks?.length || 0),
0
);
let results: ExportResult[];
try {
await fileStorage.initialize();
const exportPromises: Promise<ExportResult>[] = tags.map(async (tag) => {
try {
// Load tasks from LOCAL FileStorage to count parent tasks vs subtasks
const tasks = await fileStorage.loadTasks(tag);
const parentTaskCount = tasks.length;
const subtaskCount = tasks.reduce(
(acc, t) => acc + (t.subtasks?.length || 0),
0
);

const result =
await this.taskMasterCore!.integration.generateBriefFromTasks({
const result =
await this.taskMasterCore!.integration.generateBriefFromTasks({
tag,
options: {
generateTitle: true,
generateDescription: true,
preserveHierarchy: true,
preserveDependencies: true
}
});

if (result.success && result.brief) {
// Track exported tag
await this.trackExportedTag(tag, result.brief.id, result.brief.url);
return {
tag,
success: true,
brief: result.brief,
parentTaskCount,
subtaskCount
};
}
return {
tag,
options: {
generateTitle: true,
generateDescription: true,
preserveHierarchy: true,
preserveDependencies: true
}
});

if (result.success && result.brief) {
// Track exported tag
await this.trackExportedTag(tag, result.brief.id, result.brief.url);
success: false,
error: result.error?.message || 'Unknown error'
};
} catch (error: any) {
return {
tag,
success: true,
brief: result.brief,
parentTaskCount,
subtaskCount
success: false,
error: error.message || 'Export failed'
};
}
return {
tag,
success: false,
error: result.error?.message || 'Unknown error'
};
} catch (error: any) {
return {
tag,
success: false,
error: error.message || 'Export failed'
};
}
});
});

// Wait for all exports to complete
const results = await Promise.all(exportPromises);
spinner.stop();
// Wait for all exports to complete
results = await Promise.all(exportPromises);
spinner.stop();
} finally {
await fileStorage.close();
}

// Display results
const successful = results.filter((r) => r.success);
Expand Down
Loading
Loading