Rename ok_or_eyre to ok_or_report in OptionExt trait#272
Open
nik-rev wants to merge 1 commit intoeyre-rs:masterfrom
Open
Rename ok_or_eyre to ok_or_report in OptionExt trait#272nik-rev wants to merge 1 commit intoeyre-rs:masterfrom
ok_or_eyre to ok_or_report in OptionExt trait#272nik-rev wants to merge 1 commit intoeyre-rs:masterfrom
Conversation
This was referenced Mar 22, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Considering eyre plans to release 1.0 some time soon (#269), it's a good time to clean up the API
After renaming
eyre!toreport!(#271), renamingok_or_eyretook_or_reportwill mean we are consistent with the naming ofok_or_reportmethod, and have more of a parallel between static error creation in theNonecase of an option, and dynamic error creation: