Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

[Behat] Add Textline fieldtype BDD tests#552

Open
miguelcleverti wants to merge 1 commit into
ezsystems:masterfrom
miguelcleverti:textlineBehatTests
Open

[Behat] Add Textline fieldtype BDD tests#552
miguelcleverti wants to merge 1 commit into
ezsystems:masterfrom
miguelcleverti:textlineBehatTests

Conversation

@miguelcleverti

@miguelcleverti miguelcleverti commented Apr 18, 2016

Copy link
Copy Markdown

PlatformUI Textline BDD tests. Feature file and behat suite added.

Six test were marker with a broken tag, five of them depends on another Context(ContentType Context) that will be added later, since we are still improving the general organization of the Behat code.

The other test marked as broken still need further work however I don't think we should block this PR because of it.

Also added to the runbehat.sh script the exclusion of not working tests.

depends on: ezsystems/BehatBundle#53

@miguelcleverti

Copy link
Copy Markdown
Author

Comment thread bin/travis/runbehat.sh Outdated
cd $HOME/build/ezplatform

php bin/behat -vv --profile=platformui --tags='~@edge'
php bin/behat -vv --profile=platformui --tags='~@edge && ~@notWorking'

@andrerom andrerom Apr 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have a tag called @\broken, should use the same

@andrerom

andrerom commented Apr 25, 2016

Copy link
Copy Markdown
Contributor

+1 (however dependency in behat bundle needs to pass, and merge, and this then needs to pass, before merge here)

##
@javascript @common
Scenario: A Content of an Content Type that has a text line fieldtype must have a text field
Given a Content Type with an "text line" Field exists

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given a Content Type with a "Text Line" Field Definition exists ?
I would write our domain names with the first letter uppercased. Also, a Content Type is made of Field Definitions, not Fields

@miguelcleverti

Copy link
Copy Markdown
Author

@andrerom changed the notWorking tag to broken

@miguelcleverti

miguelcleverti commented Apr 26, 2016

Copy link
Copy Markdown
Author

@dpobel I made all the changes suggested that are specific to Text Line, I took note of the rest and will make a dedicated PR with those since they are related to FieldType Behat in general.

Scenario: A Content item of an Content Type that has a Text Line Field Definition must have a Text Line Field
Given a Content Type with an "text line" Field exists
When I create a content of this type
Then I should see a "text line" field

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify "input field" (form domain).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants