Skip to content

Backported fix for backward-compatibility issue on XMLSanitizer#246

Merged
alongosz merged 1 commit into2.3from
fix-bc-xml-entities
Apr 8, 2025
Merged

Backported fix for backward-compatibility issue on XMLSanitizer#246
alongosz merged 1 commit into2.3from
fix-bc-xml-entities

Conversation

@alongosz
Copy link
Copy Markdown
Member

@alongosz alongosz commented Apr 8, 2025

🎫 Issue Follow-up to IBX-9336

Description:

This is a 3.3 backport of ibexa/fieldtype-richtext#225

This PR fixes breaking change detected during release process.

XMLSanitizer no longer performs XML decoding on the whole document. Instead, decoding is done only when relevant lines are being processed (for safe entity detection), and is otherwise left alone and unchanged.

This prevents decoded XML (which is invalid) from making it's way into the DOMDocumentFactory.

For QA:

Sanities & check failing regression build.

@alongosz alongosz merged commit 53d1e60 into 2.3 Apr 8, 2025
20 checks passed
@alongosz alongosz deleted the fix-bc-xml-entities branch April 8, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

9 participants