-
Notifications
You must be signed in to change notification settings - Fork 1
#18 송금 요청 기능 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
#18 송금 요청 기능 #25
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2f7ba51
feat: 송금 도메인 모델
donggi-lee-bit 8646f67
feat: Data access 를 위한 Repository 클래스 뼈대
donggi-lee-bit cc0a7dd
feat: 계좌 도메인 모델에 대기 금액 필드 추가
donggi-lee-bit ee58548
feat: Remittance 도메인 생성 기능
donggi-lee-bit 6c9284d
feat: 송금 기능 개발
donggi-lee-bit fb32e3e
test: Account 클래스 출금 기능 테스트
donggi-lee-bit b63ede1
refactor: 도메인 객체 생성 후 ID 반환 로직 변경
donggi-lee-bit 235f43d
test: 송금 기능 테스트 코드 작성과 누락된 비즈니스 로직 추가
donggi-lee-bit f7327ed
refactor: 회원 조회 테스트 시 객체 간 동등 비교를 통해 검증하도록 변경
donggi-lee-bit 043d5ee
feat: 송금 요청 API
donggi-lee-bit 24b9b55
refactor: 회원 등록 시 반환되는 값 대신 저장된 회원을 직접 호출하여 ID를 사용하도록 변경
donggi-lee-bit f85a008
chore: origin 환경에서 테스트가 실패하는 문제, 원인 파악을 위해 주석 처리
donggi-lee-bit 86efbeb
chore: origin 환경에서 테스트가 실패하는 문제, 원인 파악을 위해 객체 간 비교가 아닌 ID 비교
donggi-lee-bit 4d8c037
feat: 송금 요청 시 발생하는 예외 핸들링
donggi-lee-bit dd3f346
chore: 사용하지 않는 EqualsAndHashCode 어노테이션 제거
donggi-lee-bit 0e1c691
refactor: Account 에서 출금 검증 로직을 메서드로 추출해 의미를 명확하게 표현
donggi-lee-bit 1786e55
refactor: 데이터가 조회되지 않을 경우 예외를 던지는 조회 방식의 의도를 드러내도록 네이밍 변경
donggi-lee-bit 43d7744
refactor: RemittacneHistory 조회 결과를 List 타입으로 변경하여 복수 건 조회가 가능하도록 수정
donggi-lee-bit 51c9278
refactor: 송금 요청 처리 후 관련 정보 확인 방식 변경
donggi-lee-bit f9159ee
remove: 사용되지 않는 findBySenderId 메서드 삭제
donggi-lee-bit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/main/java/com/donggi/sendzy/account/exception/AccountNotFoundException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.donggi.sendzy.account.exception; | ||
|
|
||
| import com.donggi.sendzy.common.exception.NotFoundException; | ||
|
|
||
| public class AccountNotFoundException extends NotFoundException { | ||
| public AccountNotFoundException(final Long memberId) { | ||
| super("계좌를 찾을 수 없습니다. :" + memberId); | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
src/main/java/com/donggi/sendzy/account/exception/InvalidWithdrawalException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package com.donggi.sendzy.account.exception; | ||
|
|
||
| public class InvalidWithdrawalException extends RuntimeException { | ||
| public InvalidWithdrawalException() { | ||
| super("잔액이 부족합니다."); | ||
| } | ||
|
|
||
| public InvalidWithdrawalException(final Long amount) { | ||
| super("송금액은 0원 이상이어야 합니다. 사용자 요청 금액: " + amount); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/main/java/com/donggi/sendzy/common/exception/BadRequestException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.donggi.sendzy.common.exception; | ||
|
|
||
| public class BadRequestException extends RuntimeException { | ||
| public BadRequestException(final String message) { | ||
| super(message); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
src/main/java/com/donggi/sendzy/common/exception/NotFoundException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package com.donggi.sendzy.common.exception; | ||
|
|
||
| public class NotFoundException extends RuntimeException { | ||
| public NotFoundException(final String message) { | ||
| super(message); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍