Skip to content

fix: update Fable.AST to 5.0.0-rc.3 #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Freymaurer merged 2 commits into from
Mar 20, 2026
Merged

fix: update Fable.AST to 5.0.0-rc.3 #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd07c3
fix: update `Fable.AST` to `5.0.0-rc.3`
MangelMaxime Mar 20, 2026
efff4c1
chore: update all CHANGELOG.md to trigger a release of all packages
MangelMaxime Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"fable": {
"version": "5.0.0-alpha.20",
"version": "5.0.0-rc.5",
"commands": [
"fable"
],
Expand All @@ -22,6 +22,13 @@
"fantomas"
],
"rollForward": false
},
"dotnet-outdated-tool": {
"version": "4.7.1",
"commands": [
"dotnet-outdated"
],
"rollForward": false
}
Comment on lines 24 to 32

Copilot AI Mar 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces a new local tool (dotnet-outdated-tool). If it’s not required for the Fable.AST/Fable upgrade, consider removing it from this PR (or documenting why it’s needed) to keep the change set focused.

Copilot uses AI. Check for mistakes.
}
}
}
44 changes: 22 additions & 22 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,23 @@
<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="BlackFox.CommandLine" Version="1.0.0" />
<PackageVersion Include="Fable.AST" Version="5.0.0-beta.3" />
<PackageVersion Include="Fable.Browser.Dom" Version="2.20.0" />
<PackageVersion Include="Fable.Browser.MediaQueryList" Version="1.1.0" />
<PackageVersion Include="Fable.Core" Version="4.5.0" />
<PackageVersion Include="Fable.Elmish" Version="4.0.0" />
<PackageVersion Include="Fable.Promise" Version="3.2.0" />
<PackageVersion Include="Fable.React.Types" Version="18.4.0" />
<PackageVersion Include="Fable.ReactDom.Types" Version="18.2.0" />
<PackageVersion Include="FSharp.Core" Version="8.0.401" />
<PackageVersion Include="SimpleExec" Version="12.0.0" />
<PackageVersion Include="EasyBuild.PackageReleaseNotes.Tasks" Version="2.0.0" />
<!-- dotnet testing for compilerplugins -->
<PackageVersion Include="Expecto" Version="10.2.3" />
<PackageVersion Include="YoloDev.Expecto.TestSdk" Version="0.15.5" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>
</Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="BlackFox.CommandLine" Version="1.0.0" />
<PackageVersion Include="Fable.AST" Version="5.0.0-rc.3" />
<PackageVersion Include="Fable.Browser.Dom" Version="2.20.0" />
Comment on lines +5 to +8

Copilot AI Mar 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directory.Packages.props bumps Fable.AST to 5.0.0-rc.3, but multiple committed packages.lock.json files still resolve Fable.AST to 5.0.0-beta.3 (e.g. src/Feliz.Delay/packages.lock.json, playground/src/packages.lock.json, docs/docs/feliz-docs/packages.lock.json). With RestorePackagesWithLockFile=true, restoring will rewrite those lockfiles; please regenerate/commit all affected lockfiles (or scope the change to the projects you intend to update).

Copilot uses AI. Check for mistakes.
<PackageVersion Include="Fable.Browser.MediaQueryList" Version="1.1.0" />
<PackageVersion Include="Fable.Core" Version="4.5.0" />
<PackageVersion Include="Fable.Elmish" Version="4.0.0" />
<PackageVersion Include="Fable.Promise" Version="3.2.0" />
<PackageVersion Include="Fable.React.Types" Version="18.4.0" />
<PackageVersion Include="Fable.ReactDom.Types" Version="18.2.0" />
<PackageVersion Include="FSharp.Core" Version="8.0.401" />
<PackageVersion Include="SimpleExec" Version="12.0.0" />
<PackageVersion Include="EasyBuild.PackageReleaseNotes.Tasks" Version="2.0.0" />
<!-- dotnet testing for compilerplugins -->
<PackageVersion Include="Expecto" Version="10.2.3" />
<PackageVersion Include="YoloDev.Expecto.TestSdk" Version="0.15.5" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
</ItemGroup>
</Project>
42 changes: 9 additions & 33 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/Feliz.CompilerPlugins/AstUtils.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ let makeIdent _type name : Fable.Ident = {
IsThisArgument = false
IsMutable = false
Range = None
IsInlineIfLambda = false
}

let makeUniqueIdent (name: string) =
Expand Down
6 changes: 6 additions & 0 deletions src/Feliz.CompilerPlugins/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## 3.1.0 - 2026-03-20

### 🔄 Changed

- Update `Fable.AST` to `5.0.0-rc.3` (by @MangelMaxime)

## 3.0.0 - 2025-12-10

## 3.0.0-rc.9 - 2025-12-05
Expand Down
Loading