Feature/use effect cleanup delegate - #715
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes issue #714 where React.useEffect/useEffectOnce/useLayoutEffect/useLayoutEffectOnce, when given a body that only returns a cleanup function, was compiled by Fable so that the cleanup ran immediately during setup instead of being returned. The fix routes the unit -> (unit -> unit) overloads through a new System.Func<unit, (unit -> unit)> overload (and emit-based JS) so Fable cannot inline-invoke the returned cleanup.
Changes:
- Add
Func<unit, (unit -> unit)>based overloads ofuseEffect/useEffectOnce/useLayoutEffect/useLayoutEffectOnceand delegate theunit -> (unit -> unit)overloads to them. - Add tests (
OnlyCleanupcomponents) verifying that a body returning only a cleanup runs the cleanup on unmount; restructure existing tests into nestedComponents.UseEffect/UseEffectOnce/UseLayoutEffect/UseLayoutEffectOncemodules and splitdescribeblocks per hook. - Bump CHANGELOG to 3.3.3 and modify the playground demo.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Feliz/React/React.fs | Adds Func-based overloads with explicit emitJsExpr; mass reformatting. |
| src/Feliz/CHANGELOG.md | Adds 3.3.3 release note for #714. |
| tests/Feliz/ReactBindings/UseEffect.test.fs | Refactors components into nested modules; adds OnlyCleanup regression tests. |
| tests/Feliz/ReactBindings/UseLayoutEffect.test.fs | Same restructuring + OnlyCleanup regression tests for layout effect variants. |
| playground/src/Components.fs | Replaces the lazy/Suspense demo with a small #714 reproduction; comments out LazyCounter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-once version, instead of replicating jsEmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
React.useEffect,React.useEffectOnce,React.useLayoutEffectandReact.useLayoutEffectOnceto ensure proper cleanup function handling in case of empty body.Closes #714