Rewrite optimize() to use ax.api.client.Client, remove OptimizationLoop (#5143)#5143
Open
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Open
Rewrite optimize() to use ax.api.client.Client, remove OptimizationLoop (#5143)#5143saitcakmak wants to merge 1 commit intofacebook:mainfrom
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99497269. |
meta-codesync
Bot
changed the title
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 6, 2026
…op (facebook#5143) Summary: **Goal:** Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case. The `OptimizationLoop` class in `managed_loop.py` was a legacy managed optimization loop that used `choose_generation_strategy_legacy`. This diff: - Rewrites the deprecated `optimize()` function to use the modern `ax.api.client.Client` API - Removes the `OptimizationLoop` class entirely (no external callers) - Splits `managed_loop` into its own BUCK target with minimal dependencies - Updates tests and LLM rules to reflect the changes The `optimize()` function signature and return type are preserved for backward compatibility with existing callers. Differential Revision: D99497269
saitcakmak
force-pushed
the
export-D99497269
branch
from
f36ace2 to
29bc21c
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 7, 2026
…op (facebook#5143) Summary: **Goal:** Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case. The `OptimizationLoop` class in `managed_loop.py` was a legacy managed optimization loop that used `choose_generation_strategy_legacy`. This diff: - Rewrites the deprecated `optimize()` function to use the modern `ax.api.client.Client` API - Removes the `OptimizationLoop` class entirely (no external callers) - Splits `managed_loop` into its own BUCK target with minimal dependencies - Updates tests and LLM rules to reflect the changes The `optimize()` function signature and return type are preserved for backward compatibility with existing callers. Differential Revision: D99497269
saitcakmak
force-pushed
the
export-D99497269
branch
from
29bc21c to
bfb4103
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5143 +/- ##
==========================================
- Coverage 96.42% 96.40% -0.03%
==========================================
Files 619 618 -1
Lines 69293 69214 -79
==========================================
- Hits 66818 66723 -95
- Misses 2475 2491 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saitcakmak
force-pushed
the
export-D99497269
branch
from
bfb4103 to
6c5a17e
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 20, 2026
…op (facebook#5143) Summary: **Goal:** Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case. The `OptimizationLoop` class in `managed_loop.py` was a legacy managed optimization loop that used `choose_generation_strategy_legacy`. This diff: - Rewrites the deprecated `optimize()` function to use the modern `ax.api.client.Client` API - Removes the `OptimizationLoop` class entirely (no external callers) - Splits `managed_loop` into its own BUCK target with minimal dependencies - Updates tests and LLM rules to reflect the changes The `optimize()` function signature and return type are preserved for backward compatibility with existing callers. Differential Revision: D99497269
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 20, 2026
…op (facebook#5143) Summary: **Goal:** Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case. The `OptimizationLoop` class in `managed_loop.py` was a legacy managed optimization loop that used `choose_generation_strategy_legacy`. This diff: - Rewrites the deprecated `optimize()` function to use the modern `ax.api.client.Client` API - Removes the `OptimizationLoop` class entirely (no external callers) - Splits `managed_loop` into its own BUCK target with minimal dependencies - Updates tests and LLM rules to reflect the changes The `optimize()` function signature and return type are preserved for backward compatibility with existing callers. Differential Revision: D99497269
saitcakmak
force-pushed
the
export-D99497269
branch
from
6c5a17e to
08df77c
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 20, 2026
…op (facebook#5143) Summary: Pull Request resolved: facebook#5143 **Goal:** Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case. The `OptimizationLoop` class in `managed_loop.py` was a legacy managed optimization loop that used `choose_generation_strategy_legacy`. This diff: - Rewrites the deprecated `optimize()` function to use the modern `ax.api.client.Client` API - Removes the `OptimizationLoop` class entirely (no external callers) - Splits `managed_loop` into its own BUCK target with minimal dependencies - Updates tests and LLM rules to reflect the changes The `optimize()` function signature and return type are preserved for backward compatibility with existing callers. Differential Revision: D99497269
saitcakmak
force-pushed
the
export-D99497269
branch
2 times, most recently
from
695e17f to
342a96c
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 21, 2026
…op (facebook#5143) Summary: **Goal:** Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case. The `OptimizationLoop` class in `managed_loop.py` was a legacy managed optimization loop that used `choose_generation_strategy_legacy`. This diff: - Rewrites the deprecated `optimize()` function to use the modern `ax.api.client.Client` API - Removes the `OptimizationLoop` class entirely (no external callers) - Splits `managed_loop` into its own BUCK target with minimal dependencies - Updates tests and LLM rules to reflect the changes The `optimize()` function signature and return type are preserved for backward compatibility with existing callers. Reviewed By: esantorella Differential Revision: D99497269
…op (facebook#5143) Summary: Pull Request resolved: facebook#5143 **Goal:** Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case. The `OptimizationLoop` class in `managed_loop.py` was a legacy managed optimization loop that used `choose_generation_strategy_legacy`. This diff: - Rewrites the deprecated `optimize()` function to use the modern `ax.api.client.Client` API - Removes the `OptimizationLoop` class entirely (no external callers) - Splits `managed_loop` into its own BUCK target with minimal dependencies - Updates tests and LLM rules to reflect the changes The `optimize()` function signature and return type are preserved for backward compatibility with existing callers. Reviewed By: esantorella Differential Revision: D99497269
saitcakmak
force-pushed
the
export-D99497269
branch
from
342a96c to
58c4d68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Goal: Eliminate legacy code that keeps other legacy code alive. Even though managed loop is deprecated, it has internal use cases. It seemed easier to migrate it then to try to clean up every single use case.
The
OptimizationLoopclass inmanaged_loop.pywas a legacy managed optimization loop that usedchoose_generation_strategy_legacy. This diff:optimize()function to use the modernax.api.client.ClientAPIOptimizationLoopclass entirely (no external callers)managed_loopinto its own BUCK target with minimal dependenciesThe
optimize()function signature and return type are preserved for backward compatibility with existing callers.Reviewed By: esantorella
Differential Revision: D99497269