feat(dev-server): add dev-server CLI options for HTTPS support #12082
Merged
Conversation
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +6.05 kB (+0.05%) Total Size: 12 MB 📦 View Changed
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +6.38 kB (+0.05%) Total Size: 12.4 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up of #12065
Add support for
npm run start -- --https --ssl-cert path.cert --ssl-key path.keyIn Docusaurus v3, it was previously exposed with env variables (
HTTPS,SSL_CRT_FILE,SSL_KEY_FILE), less practical/explicit.For now, we'll keep the env variables around and may remove them in the future, so they have been removed from the documentation.
If you have a good reason to use env variables, please tell us.
Test Plan
CI + local test on our own website:
Docs: https://deploy-preview-12082--docusaurus-2.netlify.app/docs/cli/#enabling-https