refactor: replace escape-string-regexp with native RegExp.escape#12150
Merged
Conversation
Docusaurus now requires Node.js >= 24.14, which ships RegExp.escape natively. Remove the escape-string-regexp dependency and the escapeRegexp wrapper from @docusaurus/utils, and call RegExp.escape directly at all call sites. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
slorber
added
the
pr: maintenance
|
Size Change: 0 B Total Size: 12 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.4 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Docusaurus now requires Node.js
>= 24.14, which shipsRegExp.escapenatively. There is no need to keep theescape-string-regexpdependency, nor theescapeRegexpwrapper abstraction in@docusaurus/utils.Changes:
packages/docusaurus-utils/src/regExpUtils.tsand theescapeRegexpexport from@docusaurus/utilsescape-string-regexpdependency from@docusaurus/utilsRegExp.escapedirectly at all call sites (theme-search-algoliavalidateThemeConfig, and front matter tests in mdx-loader / plugin-content-docs / plugin-content-blog)Note for reviewers:
escapeRegexpfrom the public@docusaurus/utilsAPI (technically breaking for third-party plugins importing it).RegExp.escapealso escapes/as\/, unlikeescape-string-regexp. This is functionally identical since the value is only ever passed tonew RegExp(from, 'g')inuseSearchResultUrlProcessor.Test Plan
pnpm vitest runon the 4 affected test files: 170 tests passpnpm --filter @docusaurus/utils --filter @docusaurus/theme-search-algolia build(tsc) passesTest links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
🤖 Generated with Claude Code