build(cmake): split test definitions into per-directory CMakeLists.txt#2646
Open
darion-yaphet wants to merge 1 commit intofacebook:mainfrom
Open
build(cmake): split test definitions into per-directory CMakeLists.txt#2646darion-yaphet wants to merge 1 commit intofacebook:mainfrom
darion-yaphet wants to merge 1 commit intofacebook:mainfrom
Conversation
Move folly_define_tests() blocks out of the root CMakeLists.txt and into individual CMakeLists.txt files co-located with their test directories. The root file now uses include() to pull them in. This makes it easier to add, remove, or modify tests for a specific module without touching the top-level build file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move folly_define_tests() blocks out of the root CMakeLists.txt and into individual CMakeLists.txt files co-located with their test directories. The root file now uses include() to pull them in.
This makes it easier to add, remove, or modify tests for a specific module without touching the top-level build file.