Take package version override from MCROUTER_PACKAGE_VERSION#478
Open
mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Open
Take package version override from MCROUTER_PACKAGE_VERSION#478mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
MCROUTER_PACKAGE_VERSION#478mszabo-wikia wants to merge 1 commit intofacebook:mainfrom
Conversation
The build system currently takes an optional package version override via the `PACKAGE_VERSION` define but this is rather generic and also used by other projects e.g. fizz. If fed into `fbcode_builder` via `--extra-cmake-defines`, it inadvertently gets used by these other projects too and can cause errors if the version override format doesn't match their expectations. So use a project-specific prefix instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build system currently takes an optional package version override via the
PACKAGE_VERSIONdefine but this is rather generic and also used by other projects e.g. fizz. If fed intofbcode_buildervia--extra-cmake-defines, it inadvertently gets used by these other projects too and can cause errors if the version override format doesn't match their expectations. So use a project-specific prefix instead.