Handle json schema consts in compiler config doc generation - #5047
Closed
captbaritone wants to merge 1 commit into
Closed
Handle json schema consts in compiler config doc generation#5047captbaritone wants to merge 1 commit into
captbaritone wants to merge 1 commit into
Conversation
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D79452138. |
Contributor
|
@captbaritone merged this pull request in b536875. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5045.
In b208fed we upgraded schemars which changed how the json schema for the compiler config is represented. It looks like the previous representation used enums of a single string literal to represent string literals. The new version uses the const keyword for string literals.
Before
After
Related: #5036