Skip to content

Commit 1e8ba76

Browse files
Julian Priestleymeta-codesync[bot]
authored andcommitted
Derive DBCM in warm bookmark cache
Summary: Currently DBCM derivation is being triggered by the derived data walker. Instead let's have the warm bookmark cache trigger the derivation, so we're guaranteed to have the data derived before the code appears in codehub. Reviewed By: clara-9 Differential Revision: D99070377 fbshipit-source-id: 6be08d53c55f8f20f38fb85ed40d027db61d5a9c
1 parent b9fd89c commit 1e8ba76

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

eden/mononoke/repo_attributes/bookmarks/warm_bookmarks_cache/BUCK

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ rust_library(
5858
"//eden/mononoke/derived_data:skeleton_manifest",
5959
"//eden/mononoke/derived_data:skeleton_manifest_v2",
6060
"//eden/mononoke/derived_data:unodes",
61+
"//eden/mononoke/derived_data:directory_branch_cluster_manifest",
6162
"//eden/mononoke/derived_data:inferred_copy_from",
6263
"//eden/mononoke/derived_data/content_manifest_derivation:content_manifest_derivation",
6364
"//eden/mononoke/derived_data/filenodes_derivation:filenodes_derivation",

eden/mononoke/repo_attributes/bookmarks/warm_bookmarks_cache/Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ content_manifest_derivation = { version = "0.1.0", path = "../../../derived_data
2222
context = { version = "0.1.0", path = "../../../servers/slapi/slapi_server/context" }
2323
deleted_manifest = { version = "0.1.0", path = "../../../derived_data/deleted_manifest" }
2424
derived_data_manager = { version = "0.1.0", path = "../../../derived_data/manager" }
25+
directory_branch_cluster_manifest = { version = "0.1.0", path = "../../../derived_data/directory_branch_cluster_manifest" }
2526
enum-map = "2.7.3"
2627
facet = { version = "0.1.0", git = "https://github.com/facebookexperimental/rust-shed.git", branch = "main" }
2728
fastlog = { version = "0.1.0", path = "../../../derived_data/fastlog" }

eden/mononoke/repo_attributes/bookmarks/warm_bookmarks_cache/src/lib.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ use context::CoreContext;
5656
use context::SessionClass;
5757
use deleted_manifest::RootDeletedManifestV2Id;
5858
use derived_data_manager::BonsaiDerivable as NewBonsaiDerivable;
59+
use directory_branch_cluster_manifest::RootDirectoryBranchClusterManifestId;
5960
use enum_map::EnumMap;
6061
use fastlog::RootFastlog;
6162
use filenodes_derivation::FilenodesOnlyPublic;
@@ -488,7 +489,13 @@ impl WarmBookmarksCacheBuilder {
488489
vec![WarmerTag::Hg, WarmerTag::Git],
489490
))
490491
}
491-
DerivableType::DirectoryBranchClusterManifest => None,
492+
DerivableType::DirectoryBranchClusterManifest => {
493+
Some(create_derived_data_warmer::<
494+
RootDirectoryBranchClusterManifestId,
495+
>(
496+
&self.ctx, repo_derived_data.clone(), vec![WarmerTag::Hg]
497+
))
498+
}
492499
DerivableType::AclManifests => None,
493500
DerivableType::TestManifests => None,
494501
DerivableType::TestShardedManifests => None,

0 commit comments

Comments
 (0)