Implement StackTraceUploader for Manifold uploads

Summary: Implement StackTraceUploader for generating manifold keys, fires background manifold upload, returns URL

Reviewed By: vilatto

Differential Revision: D96944480

fbshipit-source-id: 7e21fa2f28efda7a269136941f742a2ba81fcf6b

Author: Chandhana Solainathan

eden/fs/telemetry/BUCK

@@ -131,6 +131,25 @@ cpp_library(
     ],
 )
 
+cpp_library(
+    name = "stack_trace_uploader",
+    srcs = [
+        "StackTraceUploader.cpp",
+    ],
+    headers = [
+        "StackTraceUploader.h",
+    ],
+    deps = [
+        "fbsource//third-party/fmt:fmt",
+        "//eden/fs/rust/manifold_ffi:manifold-ffi",
+        "//eden/fs/rust/manifold_ffi:manifold-ffi@header",
+        "//folly:random",
+        "//folly/executors:cpu_thread_pool_executor",
+        "//folly/logging:logging",
+    ],
+    exported_deps = [],
+)
+
 cpp_library(
     name = "error_info",
     srcs = [

eden/fs/telemetry/StackTraceUploader.cpp

@@ -0,0 +1,67 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This software may be used and distributed according to the terms of the
+ * GNU General Public License version 2.
+ */
+
+#include "eden/fs/telemetry/StackTraceUploader.h"
+
+#include <fmt/core.h>
+#include <folly/Random.h>
+#include <folly/executors/CPUThreadPoolExecutor.h>
+#include <folly/logging/xlog.h>
+
+#include "eden/fs/rust/manifold_ffi/src/lib.rs.h"
+
+namespace facebook::eden {
+
+namespace {
+constexpr size_t kUploadPoolSize = 1;
+
+folly::CPUThreadPoolExecutor& getUploadPool() {
+  static folly::CPUThreadPoolExecutor pool(kUploadPoolSize);
+  return pool;
+}
+} // namespace
+
+std::string StackTraceUploader::generateKey() {
+  auto hi = folly::Random::rand64();
+  auto lo = folly::Random::rand64();
+  return fmt::format("flat/{:016x}{:016x}", hi, lo);
+}
+
+std::string StackTraceUploader::keyToUrl(const std::string& key) {
+  return fmt::format("manifold://{}/{}", kBucket, key);
+}
+
+std::string StackTraceUploader::uploadToManifold(std::string content) {
+  auto key = generateKey();
+  auto url = keyToUrl(key);
+
+  // Submit to a dedicated upload pool.
+  getUploadPool().add([key = std::move(key), content = std::move(content)]() {
+    try {
+      manifold_write(
+          kBucket,
+          kApiKey,
+          key,
+          rust::Slice<const uint8_t>(
+              reinterpret_cast<const uint8_t*>(content.data()), content.size()),
+          kUploadTimeoutSeconds * 1000,
+          kExpirationSeconds,
+          kClientIdentity);
+    } catch (const std::exception& ex) {
+      XLOGF(
+          WARN,
+          "Failed to upload stack trace to Manifold key={} bucket={}: {}",
+          key,
+          kBucket,
+          ex.what());
+    }
+  });
+
+  return url;
+}
+
+} // namespace facebook::eden

eden/fs/telemetry/StackTraceUploader.h

@@ -7,6 +7,7 @@
 
 #pragma once
 
+#include <cstdint>
 #include <string>
 
 namespace facebook::eden {
@@ -18,7 +19,9 @@ class StackTraceUploader {
  public:
   static constexpr const char* kBucket = "edenfs-errors-stacktraces";
   static constexpr const char* kApiKey = "edenfs-errors-stacktraces-key";
+  static constexpr const char* kClientIdentity = "edenfs_stack_trace_uploader";
   static constexpr int kUploadTimeoutSeconds = 10;
+  static constexpr uint32_t kExpirationSeconds = 30 * 24 * 60 * 60; // 30 days
 
   /**
    * Generate a unique Manifold key for a stack trace.

eden/fs/telemetry/test/BUCK

@@ -75,6 +75,18 @@ cpp_unittest(
     ],
 )
 
+cpp_unittest(
+    name = "stack_trace_uploader_test",
+    srcs = [
+        "StackTraceUploaderTest.cpp",
+    ],
+    supports_static_listing = False,
+    deps = [
+        "fbsource//third-party/googletest:gtest",
+        "//eden/fs/telemetry:stack_trace_uploader",
+    ],
+)
+
 cpp_unittest(
     name = "error_info_builder_test",
     srcs = [

eden/fs/telemetry/test/StackTraceUploaderTest.cpp

@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This software may be used and distributed according to the terms of the
+ * GNU General Public License version 2.
+ */
+
+#include "eden/fs/telemetry/StackTraceUploader.h"
+
+#include <algorithm>
+
+#include <gtest/gtest.h>
+
+namespace facebook::eden {
+
+TEST(StackTraceUploaderTest, generateKeyAndUrlFormat) {
+  auto key = StackTraceUploader::generateKey();
+  // Key format: "flat/" + 32 hex characters
+  EXPECT_EQ(key.substr(0, 5), "flat/");
+  auto rest = key.substr(5);
+  EXPECT_EQ(rest.size(), 32);
+  EXPECT_TRUE(std::all_of(rest.begin(), rest.end(), ::isxdigit))
+      << "Expected hex string, got: " << rest;
+
+  // URL should embed the bucket name and the generated key
+  auto url = StackTraceUploader::keyToUrl(key);
+  EXPECT_EQ(url, "manifold://edenfs-errors-stacktraces/" + key);
+}
+
+TEST(StackTraceUploaderTest, generateKeyIsUnique) {
+  auto key1 = StackTraceUploader::generateKey();
+  auto key2 = StackTraceUploader::generateKey();
+  EXPECT_NE(key1, key2);
+}
+
+} // namespace facebook::eden