Prevent OOM panic in Deserializable::read_batch_from#409
Open
MavenRain wants to merge 2 commits intofacebook:mainfrom
Open
Prevent OOM panic in Deserializable::read_batch_from#409MavenRain wants to merge 2 commits intofacebook:mainfrom
MavenRain wants to merge 2 commits intofacebook:mainfrom
Conversation
Replace Vec::with_capacity(num_elements) with try_reserve, returning a new TooManyElements error variant instead of panicking when a malicious input claims an absurd element count. Closes facebook#377
Merge upstream changes (tuple/primitive Deserializable impls, concise Display formatting) while retaining the TooManyElements error variant and try_reserve-based read_batch_from on the Deserializable trait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Vec::with_capacity(num_elements) with try_reserve, returning a new TooManyElements error variant instead of panicking when a malicious input claims an absurd element count.
Closes #377