This repository was archived by the owner on Jan 13, 2022. It is now read-only.
fix browser click event record#37
Open
chenglou wants to merge 1 commit intofacebookarchive:masterfrom
Open
Conversation
Contributor
Author
|
P.S. can you test this please? I'm sure it works (works on node-huxley) but I can't get pip to install something in my current directory, lol. |
Contributor
|
How about mouseup? |
Contributor
Author
|
why not mousedown? Also, mouseup might happen during a different time. |
Contributor
|
The click doesn't happen until mouseup, right? |
`click` registers twice when the clicked item is something wrapped inside a `label`, say a `checkbox`. Being recorded twice means that during the replay, the checkbox is quickly checked and unchecked. `mousedown` fixes this.
Contributor
Author
|
oh wow you're right... fixed |
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clickregisters twice when the clicked item is something wrapped inside alabel, say acheckbox. Being recorded twice means that during the replay, the checkbox is quickly checked and unchecked.mousedownfixes this.