This repository was archived by the owner on Jan 13, 2022. It is now read-only.
Properly handle specified test names#54
Open
xymostech wants to merge 2 commits intofacebookarchive:masterfrom
Open
Properly handle specified test names#54xymostech wants to merge 2 commits intofacebookarchive:masterfrom
xymostech wants to merge 2 commits intofacebookarchive:masterfrom
Conversation
Before, the available tests were just checked against the passed in comma-separated string of test names, and if they were found in the string they were run. This causes problems when you have two tests like "test" and "bettertest", because if you want to run "bettertest", it runs "test" as well. This fixes the problem by splitting the input on commas (it specifies that the list of tests should be comma-separated in the usage), so then the `in` test below checks the right thing.
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, the available tests were just checked against the passed in comma-separated string of test names, and if the test name was found somewhere in that string it would be run. This caused problems when you had two tests like
testandbettertest, because if you passed to runbettertest, it runs bothbettertestandtestas well (sincetestis a substring ofbettertest, and thus it will be found in the passed in stringbettertest).This fixes the problem by splitting the string of test names on commas (it specifies that the list of tests should be comma-separated in the usage). This way, the
inbelow (line 160) checks if the test name is in the list of tests, and doesn't have any weird substring behavior.I've signed the CLA already. Thanks!