This repository was archived by the owner on Jan 1, 2025. It is now read-only.
Add react-dom to peer dependencies#2312
Open
alirezamirian wants to merge 1 commit intofacebookexperimental:mainfrom
Open
Add react-dom to peer dependencies#2312alirezamirian wants to merge 1 commit intofacebookexperimental:mainfrom
alirezamirian wants to merge 1 commit intofacebookexperimental:mainfrom
Conversation
react-dom is an optional peer dependency which means it should be listed in peerDependencies.
facebook-github-bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-dom is an optional peer dependency which means it should be listed in peerDependencies.
An example of an issue it can cause is this error when used with Module Federation:
react-native should also be added but I didn't know what the version requirement is.