bp4f_tmp401: drop i2c auto-detection address list#22
Open
Scott8440 wants to merge 1 commit into
Open
Conversation
bp4f_tmp401 registers with legacy i2c class-based auto-detection (.class = I2C_CLASS_HWMON, .detect, .address_list = normal_i2c). At module load i2c_detect() probes every address in normal_i2c[] on every HWMON-class adapter, including the on-CPU Intel iSMT SMBus (i2c-0). That bus is unused/unresponsive on our switches, so each probe blocks for the full iSMT completion timeout (~1s), adding ~7s of "ismt_smbus ... completion wait timed out" to module load. The sensor is always instantiated explicitly by platform_manager (via new_device, matched by id_table/of_match), so address-list auto-detection is never needed. Remove normal_i2c[] and the .address_list reference; i2c_detect() now early-returns, eliminating the scan. .detect/.class are left in place but inert.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bp4f_tmp401 registers with legacy i2c class-based auto-detection (.class = I2C_CLASS_HWMON, .detect, .address_list = normal_i2c). At module load i2c_detect() probes every address in normal_i2c[] on every HWMON-class adapter, including the on-CPU Intel iSMT SMBus (i2c-0). That bus is unused/unresponsive on our switches, so each probe blocks for the full iSMT completion timeout (~1s), adding ~7s of "ismt_smbus ... completion wait timed out" to module load.
The sensor is always instantiated explicitly by platform_manager (via new_device, matched by id_table/of_match), so address-list auto-detection is never needed. Remove normal_i2c[] and the .address_list reference; i2c_detect() now early-returns, eliminating the scan. .detect/.class are left in place but inert.