Skip to content

Optimize rebatch kernel in Adsim - #198

Closed
Kaiweitu wants to merge 1 commit into
facebookresearch:v2-betafrom
Kaiweitu:export-D80209195-to-v2-beta
Closed

Optimize rebatch kernel in Adsim#198
Kaiweitu wants to merge 1 commit into
facebookresearch:v2-betafrom
Kaiweitu:export-D80209195-to-v2-beta

Conversation

@Kaiweitu

Copy link
Copy Markdown

Summary:
This diff optimizes the rebatch kernel in the following two aspects:

  • Pre-generating the requests.
  • Ensuring that the memcpy operation is not optimized out.

Reviewed By: excelle08

Differential Revision: D80209195

Summary:
This diff optimizes the rebatch kernel in the following two aspects:
- Pre-generating the requests.
- Ensuring that the memcpy operation is not optimized out.

Reviewed By: excelle08

Differential Revision: D80209195
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2025
@facebook-github-bot

Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D80209195

facebook-github-bot pushed a commit that referenced this pull request Aug 14, 2025
Summary:
Pull Request resolved: #198

This diff optimizes the rebatch kernel in the following two aspects:
- Pre-generating the requests.
- Ensuring that the memcpy operation is not optimized out.

Reviewed By: excelle08

Differential Revision: D80209195

fbshipit-source-id: e3b53260933d1559dad2bbe4a9f2c36dfb7ddcb1
@meta-cla

meta-cla Bot commented Aug 16, 2025

Copy link
Copy Markdown

Hi @Kaiweitu!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants