Add AVX512 VPOPCNT dynamic dispatch level - #5531
Open
lyang24 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Split the existing VPOPCNTDQ RaBitQ and Hamming kernels from the full Sapphire Rapids SIMD level.
DD builds now expose an
AVX512_VPOPCNTcapability for CPUs such as Ice Lake and Zen 4. The fallback chain is:AVX512_SPR -> AVX512_VPOPCNT -> AVX512 -> AVX2 -> NONEThe ordinary static AVX512 target remains unchanged and contains no VPOPCNT instructions.
Why
The VPOPCNT kernels only require baseline AVX-512 plus
AVX512_VPOPCNTDQ. Tying them to the SPR level unnecessarily excluded CPUs that support VPOPCNTDQ but not AVX512-FP16, notably Zen 4.Validation
Tested on:
AVX512_VPOPCNT, notAVX512_SPRAVX512_SPRCohere 1M IVFRaBitQ4,
nprobe=64, Zen 4:Recall, result hashes, and refinement counts were identical