Conversation
- Replace PyOxidizer with PyInstaller for building standalone binaries - Add gcm.spec and health_checks.spec for PyInstaller configuration - Update Makefile to use PyInstaller build commands - Update debian/rules for new PyInstaller output paths - Update GitHub workflows to remove Rust dependency - Update pyproject.toml to use pyinstaller instead of pyoxidizer - Update build_deb.sh to use pyinstaller - Update .gitignore to allow .spec files - Update CONTRIBUTING.md documentation PyInstaller provides better Python 3.12 support and doesn't require Rust toolchain, simplifying the build process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Replace tomli imports with tomllib (standard library in Python 3.12+) - Remove tomli dependency from pyproject.toml - Update PyInstaller spec files to remove tomli workarounds - Regenerate dev-requirements.txt with pyinstaller instead of pyoxidizer This fixes PyInstaller build issues with mypyc-compiled tomli modules by using the standard library tomllib instead.
- Move tomllib import to standard library section - Fix import ordering in all files that use tomllib - Ensures compliance with isort/usort formatting rules
- Use proper shell if/then instead of || && chain - Use find to copy everything except the executable when no _internal dir - Prevents 'rm: cannot remove directory' error
luccabb
changed the title
PyInstaller is already in dev-requirements.txt, no need to install separately.
- Include all exporter plugins (do_nothing, stdout, file, otel, graph_api) - Fixes sink validation errors in health_checks - Ensures exporters.registry can discover all sink plugins
This is a proper Python 3.12 migration - use the stdlib tomllib module directly instead of maintaining compatibility with the old tomli package name. Changes: - import tomllib (not import tomllib as tomli) - tomllib.load() and tomllib.TOMLDecodeError everywhere 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Hi @luccabb! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Summary
Test Plan