Fixes validation errors - #26
Conversation
|
Hi @tshu-w! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
@RomainFrog any idea on what that line does there and what's up with #25 ? |
|
Despite applying this patch, we continue to observe a substantial gap in performance.
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
3677dc3 to
8b3d5c2
Compare
|
I can confirm that this patch also improves metrics on my side when I evaluate Llama-3.3-70b-Instruct mini config: |
🎯 Type of Change
🏗️ Meta Agents Research Environments Components Affected
are/simulation/environment.py,are/simulation/core/, environment setup/configuration)are/simulation/gui/, web interface, client-side components)are/simulation/scenarios/, scenario definitions, scenario runner)are/simulation/agents/, agent implementations)🔗 Related Issues
Fixes #25
🧪 Testing Strategy
Test Details
🤖 AI Usage Declaration
No using.
📸 Screenshots/Recordings
📋 Checklist
Fixes validation errors when using LiteLLM as the LLM provider.