Skip to content

Fixes validation errors - #26

Open
tshu-w wants to merge 1 commit into
facebookresearch:mainfrom
tshu-w:fix-litellm
Open

Fixes validation errors#26
tshu-w wants to merge 1 commit into
facebookresearch:mainfrom
tshu-w:fix-litellm

Conversation

@tshu-w

@tshu-w tshu-w commented Nov 12, 2025

Copy link
Copy Markdown

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes, no api changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or improvement
  • 🔨 Build/CI changes

🏗️ Meta Agents Research Environments Components Affected

  • Environment (are/simulation/environment.py, are/simulation/core/, environment setup/configuration)
  • UI/GUI (are/simulation/gui/, web interface, client-side components)
  • Scenarios (are/simulation/scenarios/, scenario definitions, scenario runner)
  • Agents (are/simulation/agents/, agent implementations)
  • Documentation (README, docs, comments)
  • Build/CI (GitHub Actions, Docker, dependencies)

🔗 Related Issues

Fixes #25

🧪 Testing Strategy

  • Unit Tests: Added/updated unit tests
  • Integration Tests: Tested integration with other components
  • Manual Testing: Manually verified functionality
  • Scenario Testing: Ran specific scenarios to validate changes
  • GUI Testing: Tested web interface (if applicable)
  • Regression Testing: Verified existing functionality still works

Test Details

🤖 AI Usage Declaration

No using.

📸 Screenshots/Recordings

⚠️ Breaking Changes

📋 Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Fixes validation errors when using LiteLLM as the LLM provider.

@meta-cla

meta-cla Bot commented Nov 12, 2025

Copy link
Copy Markdown

Hi @tshu-w!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@tshu-w tshu-w changed the title 📋 Summary Fixes validation errors when using LiteLLM as the LLM provider. Nov 12, 2025
@Mortimerp9

Copy link
Copy Markdown
Contributor

@RomainFrog any idea on what that line does there and what's up with #25 ?

@tshu-w

tshu-w commented Nov 13, 2025

Copy link
Copy Markdown
Author

Despite applying this patch, we continue to observe a substantial gap in performance.

Model Execution Search Ambiguity Adaptability Time Noise Agent2Agent
gemini-2.5-pro(fixBool) 27.5%±1.6% 48.3% 15.0%±1.0% 10.4%±0.8% 7.9%±0.4% 17.1%±0.2% 11.7%±1.4%

@meta-cla meta-cla Bot added the cla signed label Nov 13, 2025
@meta-cla

meta-cla Bot commented Nov 13, 2025

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@tshu-w
tshu-w force-pushed the fix-litellm branch 2 times, most recently from 3677dc3 to 8b3d5c2 Compare November 14, 2025 04:13
@maxkochanoff

Copy link
Copy Markdown

I can confirm that this patch also improves metrics on my side when I evaluate Llama-3.3-70b-Instruct

mini config:
0.1% -> 0.4% for both macro and micro success rates in global summary

@tshu-w tshu-w changed the title Fixes validation errors when using LiteLLM as the LLM provider. Fixes validation errors Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BENCHMARK BUG] Gaia2: Gemini‑2.5‑Pro scores far below paper

3 participants