Security: Unsafe signed byte-count passed to cudaMemcpyAsync - #2027
Conversation
The CUDA memcpy helpers accept `const int& size` and pass it directly to `cudaMemcpyAsync`, which expects an unsigned byte count (`size_t`). If a negative or overflowed value reaches these helpers, implicit conversion can produce a huge copy size, risking out-of-bounds device/host memory access. Affected files: util.cpp Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
|
Hi @tuanaiseo! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Problem
The CUDA memcpy helpers accept
const int& sizeand pass it directly tocudaMemcpyAsync, which expects an unsigned byte count (size_t). If a negative or overflowed value reaches these helpers, implicit conversion can produce a huge copy size, risking out-of-bounds device/host memory access.Severity:
highFile:
pytorch3d/csrc/pulsar/pytorch/util.cppSolution
Change the API to use
size_tfor byte counts, and add explicit sanity checks (non-negative, expected maximum, and source/destination capacity) before issuing async copies.Changes
pytorch3d/csrc/pulsar/pytorch/util.cpp(modified)Testing