Security: Unclosed File Handle in YAML Loading - #2031
Conversation
In `build_count.py`, `yaml.safe_load(open('config.yml'))` opens a file but never explicitly closes the file handle. While `yaml.safe_load` is used (avoiding YAML deserialization attacks), the file descriptor leak could be problematic in long-running processes or resource-constrained environments.
Affected files: build_count.py
Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
|
Hi @barttran2k! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
1 participant
Problem
In
build_count.py,yaml.safe_load(open('config.yml'))opens a file but never explicitly closes the file handle. Whileyaml.safe_loadis used (avoiding YAML deserialization attacks), the file descriptor leak could be problematic in long-running processes or resource-constrained environments.Severity:
lowFile:
.circleci/build_count.pySolution
Use a context manager:
with open('config.yml') as f: conf = yaml.safe_load(f)Changes
.circleci/build_count.py(modified)Testing