Security: Type punning via IASF macro causes undefined behavior

[barttran2k]

Problem

In renderer.fill_bg.device.h, the IASF macro is used to store an integer value (sphere_id = -1) into a float memory location via type punning. This is undefined behavior in C++ unless performed through memcpy or std::bit_cast. Compilers may optimize this incorrectly under strict aliasing rules, leading to unpredictable behavior.

Severity: low
File: pytorch3d/csrc/pulsar/include/renderer.fill_bg.device.h

Solution

Use memcpy for type punning instead of the IASF macro to ensure well-defined behavior: memcpy(&renderer.forw_info_d[write_loc + 3 + i * 2], &sphere_id, sizeof(float));

Changes

• pytorch3d/csrc/pulsar/include/renderer.fill_bg.device.h (modified)

Testing

• Existing tests pass
• Manual review completed
• No new warnings/errors introduced

[meta-cla]

Hi @barttran2k!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!