Fix coordinate indexing in frustum face culling - #2044
Open
tandede wants to merge 1 commit into
Open
Conversation
|
@bottler has imported this pull request. If you are a Meta employee, you can view this in D117200371. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the coordinate indexing used by frustum face culling.
face_vertshas shape[F, 3, 3], where the last two dimensions are vertex and xyz coordinate respectively._get_culled_facespreviously indexed it asface_verts[:, axis], which selected one vertex from every face instead of selecting the requested coordinate from all three vertices. The subsequent reduction could therefore miss faces fully outside a clipping plane and cull faces that only had one outside vertex.This change selects the coordinate with
face_verts[:, :, axis]and usesall(dim=1)to express the intended condition directly: a face is culled only when all three vertices lie outside the same frustum plane.The regression test covers all six frustum planes and verifies that a face intersecting the left plane stays visible for three different vertex orders.
Fixes #1936.
Validation
git diff --checkpass for the changed files.tests/test_render_meshes_clipped.pyrequire CUDA and cannot run in the local CPU-only PyTorch environment; the focused regression is CPU-only, and the repository CI will cover the CUDA test matrix.