Rename underscore-prefixed binding factory functions to make_something - #1384
Merged
Conversation
The stub generator skips symbols prefixed with underscores, so factory functions like `_demuxer`, `_make_bsf`, `_make_decoder`, and `_nvdec_decoder` were missing from the generated `.pyi` stub files. This made it difficult for type checkers and tooling to understand the codebase. Renamed the bindings as follows: - `_demuxer` -> `make_demuxer` (demuxing.cpp, 2 overloads) - `_make_bsf` -> `make_bsf` (bsf.cpp, 3 overloads) - `_make_decoder` -> `make_decoder` (decoding.cpp, 3 overloads) - `_nvdec_decoder` -> `make_nvdec_decoder` (decoding_nvdec.cpp) Updated all call sites in `_core.py` and regenerated stub files.
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D102682526. (Because this pull request was imported automatically, there will not be any future comments.) |
mthrok
marked this pull request as ready for review
April 27, 2026 22:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stub generator skips symbols prefixed with underscores, so factory functions like
_demuxer,_make_bsf,_make_decoder, and_nvdec_decoderwere missing from the generated.pyistub files.This made it difficult for type checkers and tooling to understand the codebase.
Renamed the bindings as follows:
_demuxer->make_demuxer(demuxing.cpp, 2 overloads)_make_bsf->make_bsf(bsf.cpp, 3 overloads)_make_decoder->make_decoder(decoding.cpp, 3 overloads)_nvdec_decoder->make_nvdec_decoder(decoding_nvdec.cpp)Updated all call sites in
_core.pyand regenerated stub files.