[pipeline] Move isolating-pool executor helpers to _common/_convert - #1580
Merged
Conversation
mthrok
marked this pull request as ready for review
July 2, 2026 01:07
meta-cla
Bot
added
the
CLA Signed
Pure refactor, no behavior change. Moves the executor-classification helpers `_is_isolating_pool` and `_is_interpreter_pool` — and the `_INTERPRETER_POOL_CLASS` version guard they depend on — from `spdl/pipeline/_fuse.py` into `spdl/pipeline/_common/_convert.py`, next to the existing `_is_process_pool` they build on. `_common/_convert` sits low in the import graph, so hosting the helpers there lets other modules (notably `spdl/pipeline/defs`) reuse them without importing `_fuse` and creating an import cycle. `_fuse` now imports `_is_isolating_pool` from `_common/_convert` instead of defining it. Extracted from #1579
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D110410382. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor, no behavior change. Moves the executor-classification helpers
_is_isolating_pooland_is_interpreter_pool— and the_INTERPRETER_POOL_CLASSversion guard they depend on — fromspdl/pipeline/_fuse.pyintospdl/pipeline/_common/_convert.py, next to the existing_is_process_poolthey build on._common/_convertsits low in the import graph, so hosting the helpers there lets other modules (notablyspdl/pipeline/defs) reuse them without importing_fuseand creating an import cycle._fusenow imports_is_isolating_poolfrom_common/_convertinstead of defining it.Extracted from #1579