Remove Pyre mode headers in fbcode/spdl - #1613
Merged
meta-codesync[bot] merged 1 commit intoAug 26, 2026
Merged
Conversation
Summary: Remove standalone `# pyre-strict` and `# pyre-unsafe` mode headers from Python files under `fbcode/spdl`. Pyrefly type-checks all files in one consistent mode, so these legacy per-file mode headers no longer have an effect. Other Pyre directives and generated files are left unchanged.Pyrefly is now the default type checker across FBCode so this diff introduces no functional changes. #pyreupgrade Differential Revision: D117256028
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@maggiemoss has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117256028. |
meta-codesync
Bot
merged commit Aug 26, 2026
9e8554a
into
facebookresearch:main
105 of 108 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove standalone
# pyre-strictand# pyre-unsafemode headers from Python files underfbcode/spdl.Pyrefly type-checks all files in one consistent mode, so these legacy per-file mode headers no longer have an effect. Other Pyre directives and generated files are left unchanged.Pyrefly is now the default type checker across FBCode so this diff introduces no functional changes.
#pyreupgrade
Differential Revision: D117256028