Add self-capture support (Closes issue #608)#919
Open
Belzedar94 wants to merge 14 commits intofairy-stockfish:masterfrom
Open
Add self-capture support (Closes issue #608)#919Belzedar94 wants to merge 14 commits intofairy-stockfish:masterfrom
Belzedar94 wants to merge 14 commits intofairy-stockfish:masterfrom
Conversation
Add Variant::ironPieceTypes and parser support; disallow capturing iron pieces (incl. en passant); document key and demo variant [iron-pawns:chess].
Add iron/uncapturable pieces support (Fixes fairy-stockfish#606)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
make -j2 ARCH=x86-64 buildpython3 test.pyThis has been carefully vibe-coded, but passes all the tests and work locally as far as I tested. It took a bit of back and forth.
Nevertheless, a careful review from an expert is definitely needed