Add devcontainer configuration for development environment#982
Open
DavidHock07 wants to merge 2 commits intofairy-stockfish:masterfrom
Open
Add devcontainer configuration for development environment#982DavidHock07 wants to merge 2 commits intofairy-stockfish:masterfrom
DavidHock07 wants to merge 2 commits intofairy-stockfish:masterfrom
Conversation
Member
|
Thanks a lot for the PR. I honestly don't have too much experience with dev container best practices, but the config looks very reasonable to me and in a quick test worked well, so looks like a good addition. Do you think it makes sense to add volume mounts to common environment dependent local folders like .venv and tests/js/node_modules to isolate from the host? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.