Synchronize main project (Closing Milestone v14.0.2)#17
Closed
yjf2002ghty wants to merge 5 commits intofairy-stockfish:nnuefrom
yjf2002ghty:nnue
Closed
Synchronize main project (Closing Milestone v14.0.2)#17yjf2002ghty wants to merge 5 commits intofairy-stockfish:nnuefrom yjf2002ghty:nnue
yjf2002ghty wants to merge 5 commits intofairy-stockfish:nnuefrom
yjf2002ghty:nnue
Conversation
Member
|
Thanks. However, for the dependent projects like wasm and NNUE data generator I prefer to directly merge from the upstream project to keep the history clean, otherwise this might create future merge conflicts. With respect to the CI, my assumption is that there would be no need to remove the publish step, since this is only triggered by tag creation, so nobody without the required write access can do it by accident. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request merges recent changes like fairy-stockfish/Fairy-Stockfish#780 and fairy-stockfish/Fairy-Stockfish#792 . If there are any changes, you can apply the changes based on this pull request which can save time.
Note that I removed the "Publish to NPM" step in the CI as I'm not the publisher. Adding back it is needed before or after merging.
I've tested it in the CI and it passed.
