Fix #797: Iterate over brands as an array#798
Merged
Conversation
anulman
force-pushed
the
aidan/fix-brands-iteration
branch
from
July 17, 2025 21:09
7ea14f8 to
d78e8bc
Compare
faisalman
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Type of Change
Bug fix
Description
I observed script failures on sites that mangle the
Array.prototypeand opened #797. This PR changes two instances wherefor...inloops were including prototype methods of arrays vs. the items they enumerate.Test
I first ran the script manually on a site that mangled the
Array.prototypewith anisEmptymethod. When this worked, I came to contribute. See the provided test for something that used to fail and now succeeds.Impact
If users previously relied on
setPropspassing non-owned properties to the result, this would be a breaking change.Since that seems like unexpected behaviour, that's probably more of a bugfix though :)