Improve existing browser detection for Tiktok#817
Merged
Conversation
Contributor
Author
|
Hey Mas @faisalman, could you review this when you have a of bit time. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Type of Change
Feature
Description
This PR will improves the detection of Tiktok's WebView user agents
Currently user agent captured from TikTok iOS v43.0.0 (and likely in many recent versions) is detected as Mobile Safari as seen on the Demo below.
Demo:
https://uaparser.dev/?ua=Mozilla/5.0%20(iPhone;%20CPU%20iPhone%20OS%2018_6_2%20like%20Mac%20OS%20X)%20AppleWebKit/605.1.15%20(KHTML,%20like%20Gecko)%20Mobile/15E148%20Safari/604.1%20trill_43.0.0%20BytedanceWebview/d8a21c6#demo
{ "ua": "Mozilla/5.0 (iPhone; CPU iPhone OS 18_6_2 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Mobile/15E148 Safari/604.1 trill_43.0.0 BytedanceWebview/d8a21c6", "browser": { "name": "Mobile Safari" }, "cpu": {}, "device": { "type": "mobile", "model": "iPhone", "vendor": "Apple" }, "engine": { "name": "WebKit", "version": "605.1.15" }, "os": { "name": "iOS", "version": "18.6.2" } }Test
Impact
No breaking changes and is backwards compatible. This PR only improves the existing Tiktok's WebView detection
Other Info