Skip to content

Add icons directory to package files#823

Merged
faisalman merged 1 commit into
faisalman:masterfrom
Pek5892:patch-1
Jan 24, 2026
Merged

Add icons directory to package files#823
faisalman merged 1 commit into
faisalman:masterfrom
Pek5892:patch-1

Conversation

@Pek5892

@Pek5892 Pek5892 commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Prerequisites

Type of Change

feature

Description

Added icons directory to package files for uses

@faisalman
faisalman merged commit fc709c2 into faisalman:master Jan 24, 2026
6 checks passed
@hyperz111

hyperz111 commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

@Pek5892, why we need this? Because from https://packagephobia.com/result?p=ua-parser-js, this change make the install size 2 times bigger (again).

@hyperz111

Copy link
Copy Markdown
Contributor

@faisalman, maybe you can revert this change?

@Pek5892

Pek5892 commented Feb 17, 2026

Copy link
Copy Markdown
Contributor Author

@hyperz111 to include icons on the library

@myersbrittanym-art

myersbrittanym-art commented Feb 17, 2026 via email

Copy link
Copy Markdown

@hyperz111

Copy link
Copy Markdown
Contributor

@hyperz111 to include icons on the library

But this is unused and useless.

@askoufis

askoufis commented May 11, 2026

Copy link
Copy Markdown

@faisalman @Pek5892 Can the reason for including these icons in the package be listed explicitly somewhere? Ideally in the readme, or at least in this PR. I couldn't find any reference to the icons in the code, so I don't understand why they're include in the published package. If they are not needed, then they should be removed.

I consider it beyond the scope of this package's API to handle anything to do with browser/OS icons, so if there is some kind of planned future API that does involve them, maybe it should be published as a separate package instead.

Increasing the size of a package by 830kb (~163%) for no apparent reason and with inadequate communication (the only mention of this was a single line in the changelog) is unacceptable for such a widely used package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants