Add icons directory to package files#823
Conversation
|
@Pek5892, why we need this? Because from https://packagephobia.com/result?p=ua-parser-js, this change make the install size 2 times bigger (again). |
|
@faisalman, maybe you can revert this change? |
|
@hyperz111 to include icons on the library |
|
I don't remember subscribing to this.. what is this? Why does it say merge?
…On Tue, Feb 17, 2026 at 1:00 AM Valentina ***@***.***> wrote:
*Pek5892* left a comment (faisalman/ua-parser-js#823)
<#823 (comment)>
@hyperz111 <https://github.com/hyperz111> to include icons on the library
—
Reply to this email directly, view it on GitHub
<#823 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BV56SQ3STCPC7TKX6J2FCUL4MLKDXAVCNFSM6AAAAACSNILD3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSMJTGE4DQMJQGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
But this is unused and useless. |
|
@faisalman @Pek5892 Can the reason for including these icons in the package be listed explicitly somewhere? Ideally in the readme, or at least in this PR. I couldn't find any reference to the icons in the code, so I don't understand why they're include in the published package. If they are not needed, then they should be removed. I consider it beyond the scope of this package's API to handle anything to do with browser/OS icons, so if there is some kind of planned future API that does involve them, maybe it should be published as a separate package instead. Increasing the size of a package by 830kb (~163%) for no apparent reason and with inadequate communication (the only mention of this was a single line in the changelog) is unacceptable for such a widely used package. |
Prerequisites
Type of Change
feature
Description
Added icons directory to package files for uses