Skip to content

Task-93807 Remove 10 UN Member States miscategorized in territoryCodes.json#188

Open
vichugofsl wants to merge 1 commit into
developfrom
bug-93807-remove-10-un-member-states-miscategorized-territorycodes-json
Open

Task-93807 Remove 10 UN Member States miscategorized in territoryCodes.json#188
vichugofsl wants to merge 1 commit into
developfrom
bug-93807-remove-10-un-member-states-miscategorized-territorycodes-json

Conversation

@vichugofsl

@vichugofsl vichugofsl commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Issue Link

Bug 93807: Remove 10 UN Member States miscategorized in territoryCodes.json

PR Summary: Unhide 10 UN Member States from the country selector

Description

Users in several countries could not find their nation in the country drop-down on live.bible.is, even though languages for those regions exist in the catalog (confirmed by partners in Timor-Leste).

The country list is filtered by app/utils/territoryCodes.json — any country whose ISO iso_a2 code is a key in this file is excluded.

Change

Removed 10 country codes from app/utils/territoryCodes.json:

Code UN Member State
AG Antigua and Barbuda
CV Cabo Verde
MH Marshall Islands
SC Seychelles
SM San Marino
ST Sao Tome and Principe
TL Timor-Leste
TT Trinidad and Tobago
VC Saint Vincent and the Grenadines
WS Samoa

The filter lives in getCountries() at app/containers/TextSelection/saga.js:49. No code changes were needed — removing the keys lets these countries flow through to the dropdown.

Verification

  • npm run lint:js — 0 errors.
  • npm run test — 79 suites pass (491 passed, 2 skipped, 115 snapshots). The
    CountryList snapshot tests use fixed test data and are unaffected.
  • Manual: the 10 nations now appear in the country selector and can be selected to show their available languages.

Screenshot

You can see a screenshot after applied the current change.
Screenshot_2026-06-17_11-12-38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a set of ISO A2 country codes from app/utils/territoryCodes.json, which is used by getCountries() to exclude entries from the country selector. This change allows the affected UN member states to appear in the country dropdown again.

Changes:

  • Removed 10 ISO A2 codes (AG, CV, MH, SC, SM, ST, TL, TT, VC, WS) from the territory exclusion list.
  • Kept the JSON valid (no trailing-comma issues after deletions).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants