Task-93807 Remove 10 UN Member States miscategorized in territoryCodes.json#188
Open
vichugofsl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes a set of ISO A2 country codes from app/utils/territoryCodes.json, which is used by getCountries() to exclude entries from the country selector. This change allows the affected UN member states to appear in the country dropdown again.
Changes:
- Removed 10 ISO A2 codes (AG, CV, MH, SC, SM, ST, TL, TT, VC, WS) from the territory exclusion list.
- Kept the JSON valid (no trailing-comma issues after deletions).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samschlenker
approved these changes
Jun 17, 2026
robertoSolaresFSL
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
Bug 93807: Remove 10 UN Member States miscategorized in territoryCodes.json
PR Summary: Unhide 10 UN Member States from the country selector
Description
Users in several countries could not find their nation in the country drop-down on live.bible.is, even though languages for those regions exist in the catalog (confirmed by partners in Timor-Leste).
The country list is filtered by
app/utils/territoryCodes.json— any country whose ISOiso_a2code is a key in this file is excluded.Change
Removed 10 country codes from
app/utils/territoryCodes.json:The filter lives in
getCountries()atapp/containers/TextSelection/saga.js:49. No code changes were needed — removing the keys lets these countries flow through to the dropdown.Verification
npm run lint:js— 0 errors.npm run test— 79 suites pass (491 passed, 2 skipped, 115 snapshots). TheCountryListsnapshot tests use fixed test data and are unaffected.Screenshot
You can see a screenshot after applied the current change.
