Skip to content

feat(client): support passing hints as x-fal-runner-hint#143

Merged
efiop merged 1 commit intomainfrom
ruslan/hint
Jul 14, 2025
Merged

feat(client): support passing hints as x-fal-runner-hint#143
efiop merged 1 commit intomainfrom
ruslan/hint

Conversation

@efiop
Copy link
Copy Markdown
Contributor

@efiop efiop commented Jul 13, 2025

python client already has it, but turns out we never had it in js client https://docs.fal.ai/private-serverless-apps/optimizations/hot-app-routing

@efiop efiop requested a review from Copilot July 13, 2025 22:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for passing a runner hint via a new hint option, which is sent as the X-Fal-Runner-Hint header in queue requests.

  • Introduce hint?: string in SubmitOptions
  • Destructure hint from options and conditionally include it in request headers
Comments suppressed due to low confidence (1)

libs/client/src/queue.ts:257

  • There are no tests verifying that the hint option correctly adds the X-Fal-Runner-Hint header. Please add unit or integration tests to cover this new behavior.
          ...(hint && { "x-fal-runner-hint": hint }),

@efiop efiop requested a review from drochetti July 13, 2025 22:12
@efiop efiop merged commit 7d138d5 into main Jul 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants