Skip to content

feat: added user-defined timeouts#182

Merged
dberkerdem merged 6 commits intomainfrom
daglar/infra-319
Jan 23, 2026
Merged

feat: added user-defined timeouts#182
dberkerdem merged 6 commits intomainfrom
daglar/infra-319

Conversation

@dberkerdem
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear bot commented Jan 21, 2026

@dberkerdem dberkerdem marked this pull request as ready for review January 21, 2026 09:54
@efiop efiop requested a review from drochetti January 23, 2026 14:29
Copy link
Copy Markdown
Collaborator

@drochetti drochetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it! 🚀

Could you bump the minor version of the client/package.json so we can release it?

@@ -0,0 +1,67 @@
import {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding these!

Comment on lines +35 to +41
if (!(error instanceof ApiError)) {
return false;
}
// User-specified timeouts should NOT be retried
if (error.isUserTimeout) {
return false;
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call!

@dberkerdem dberkerdem merged commit c72e7d4 into main Jan 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants