Skip to content

feat(proto): add pagination to ListApplications #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hanchchch wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(proto): add pagination to ListApplications #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions projects/isolate_proto/src/isolate_proto/controller.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,13 @@ message UpdateApplicationResult {
message ListApplicationsRequest {
optional string application_name = 1;
optional string environment_name = 2;
// Maximum number of revisions to return. The server clamps this to its own
// ceiling and applies a default when unset, so a client that omits it still
// cannot request an unbounded result set.
optional int32 page_size = 3;
// Opaque cursor taken from a previous response's `next_page_token`. Treat it
// as a black box; the encoding is a server implementation detail.
optional string page_token = 4;
}

message ApplicationInfo {
Expand All @@ -455,6 +462,10 @@ message ApplicationInfo {

message ListApplicationsResult {
repeated ApplicationInfo applications = 1;
// Cursor for the next page, absent on the last page. Callers that page must
// stop when this is unset rather than when a page comes back short: the
// server may return fewer rows than `page_size` and still have more.
optional string next_page_token = 2;
}

message DeleteApplicationRequest {
Expand Down
Loading
Loading