fix: Symlink rustfmt instead of copying#43
Conversation
PR SummaryLow Risk Overview That keeps Reviewed by Cursor Bugbot for commit 27efecb. Bugbot is set up for automated code reviews on this repo. Configure here. |
tlater-famedly
left a comment
There was a problem hiding this comment.
LGTM, in spite of my preference on how this file is commented.
| # We want *only* the rustfmt binaries. This trick doesn't | ||
| # really work for other components of the rust toolchain, | ||
| # but specifically rustfmt is quite self-contained. |
There was a problem hiding this comment.
Nit: We should keep this comment in addition to the new one. This comment explains why overriding parts of the toolchain like this is fine, the other one explains why we're symlinking instead of copying.
d42d6e6 to
27efecb
Compare
This should solve an issue I was having on aarch64-darwin where the rustfmt binary is apparently dynamically linked.