fix: scope token insteadOf rewrites to the famedly org#77
Merged
Conversation
Rewriting all of github.com injects the token into clones of public repositories as well. Xcode's Swift Package Manager cannot handle the rewritten URLs with embedded credentials and hangs indefinitely during dependency resolution (Firebase, Sentry, etc.) on iOS builds. Scoping the rewrites to github.com/famedly/ keeps authentication for the private dependencies while leaving public clones untouched.
krille-chan
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insteadOfrewrites indart-preparecurrently rewrite allgithub.qkg1.topURLs, injecting the token into clones of public repositories as well.build_iosin famedly/app#7173, where the job stalled for 28+ minutes afterFetching from https://github.com/google/GoogleAppMeasurement.git...while an identical build without the token path finishes in ~13 minutes.github.com/famedly/. Private famedly dependencies keep working via the token; public clones (incl. all SPM packages) stay untouched. As a side effect the token is no longer attached to every GitHub clone.